qx.util.TimerManager initialTime

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

qx.util.TimerManager initialTime

kreimer
Hi. Before hand.. I want to say this is sort of trivial and has little importance (once you have workaround).

from the api docs of TimerManager#start...
" initialTime Milliseconds before the callback function is called the very first time. If not specified and recurTime is specified, then recurTime will be used as initialTime; otherwise initialTime will default to zero. "

I've tried:
qx.util.TimerManager.getInstance().start(this._refresh, 20000, this, null, 0);

and noticed that _refresh is not invoked when starting the timer. I change the last arg from 0 to 1 (1 millisecond) and worked as I expected.

Looking at the code

https://github.com/qooxdoo/qooxdoo/blob/release_5_0_1/framework/source/class/qx/util/TimerManager.js#L135

      if (! initialTime) {...

if you specify 0 as the value of initialTime the if statement will evaluate to true (0 is cast to false I think in js) and then will make initialTime value the recurTime.

As I said... no big matter for 1 millisecond..

Cheers everybody on the team and thanks for all the fish!

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: qx.util.TimerManager initialTime

Derrell Lipman
Thanks for the report!

That has now been fixed in master. If you're not pulling directly from git, you can just change:

if (! initialTime)

to

if (typeof initialTime != "number")

Derrell


On Wed, Jan 27, 2016 at 4:34 PM kreimer <[hidden email]> wrote:
Hi. Before hand.. I want to say this is sort of trivial and has little
importance (once you have workaround).

from the api docs of TimerManager#start...
" initialTime Milliseconds before the callback function is called the very
first time. If not specified and recurTime is specified, then recurTime will
be used as initialTime; otherwise initialTime will default to zero. "

I've tried:
qx.util.TimerManager.getInstance().start(this._refresh, 20000, this, null,
0);

and noticed that _refresh is not invoked when starting the timer. I change
the last arg from 0 to 1 (1 millisecond) and worked as I expected.

Looking at the code

https://github.com/qooxdoo/qooxdoo/blob/release_5_0_1/framework/source/class/qx/util/TimerManager.js#L135

      if (! initialTime) {...

if you specify 0 as the value of initialTime the if statement will evaluate
to true (0 is cast to false I think in js) and then will make initialTime
value the recurTime.

As I said... no big matter for 1 millisecond..

Cheers everybody on the team and thanks for all the fish!





--
View this message in context: http://qooxdoo.678.n2.nabble.com/qx-util-TimerManager-initialTime-tp7587958.html
Sent from the qooxdoo mailing list archive at Nabble.com.

------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Loading...