qx.ui.table.celleditor.ComboBox improvement

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

qx.ui.table.celleditor.ComboBox improvement

Romain FLIEDEL
Hi,

I'm using various table cell editor but my users complains about the
fact that you have to click on a different cell of the table to stop
editing.
For instance you can improve the combobox editor by adding an event
listener on "changeSelected" to call the stopEditing() on the table (See
the patch bellow).
You could use the same kind of improvement for checkbox with the
"changeChecked" event.
The only remaining problem is for textEditor where you have to lost
focus to trigger a "changeValue"


Index: ComboBox.js
===================================================================
--- ComboBox.js    (revision 14302)
+++ ComboBox.js    (working copy)
@@ -100,6 +100,16 @@
       cellEditor.setBorder(null);
       cellEditor.originalValue = cellInfo.value;
 
+
+      cellEditor.addEventListener(
+        "changeValue",
+        function()
+        {
+            cellInfo.table.stopEditing();
+        },
+        this
+      );
+
       var field = cellEditor.getField();
       field.setLiveUpdate(true);
       field.setAppearance("table-editor-textfield");


This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.



-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|

Re: qx.ui.table.celleditor.ComboBox improvement

Fabian Jakobs
Administrator
Hi Romain,

> Hi,
>
> I'm using various table cell editor but my users complains about the
> fact that you have to click on a different cell of the table to stop
> editing.
> For instance you can improve the combobox editor by adding an event
> listener on "changeSelected" to call the stopEditing() on the table (See
> the patch bellow).
> You could use the same kind of improvement for checkbox with the
> "changeChecked" event.
> The only remaining problem is for textEditor where you have to lost
> focus to trigger a "changeValue"
>
>  
You could catch the ENTER key to stop editing in the text field.

Can you please open a bug report for this and attach you patch. This
really helps us to organize such improvements.

Best Fabian


> Index: ComboBox.js
> ===================================================================
> --- ComboBox.js    (revision 14302)
> +++ ComboBox.js    (working copy)
> @@ -100,6 +100,16 @@
>        cellEditor.setBorder(null);
>        cellEditor.originalValue = cellInfo.value;
>  
> +
> +      cellEditor.addEventListener(
> +        "changeValue",
> +        function()
> +        {
> +            cellInfo.table.stopEditing();
> +        },
> +        this
> +      );
> +
>        var field = cellEditor.getField();
>        field.setLiveUpdate(true);
>        field.setAppearance("table-editor-textfield");
>
>
> This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
>
>
>
> -------------------------------------------------------------------------
> Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
> Studies have shown that voting for your favorite open source project,
> along with a healthy diet, reduces your potential for chronic lameness
> and boredom. Vote Now at http://www.sourceforge.net/community/cca08
> _______________________________________________
> qooxdoo-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
>
>
>  


--
Fabian Jakobs
JavaScript Framework Developer

1&1 Internet AG
BrauerstraƟe 48
76135 Karlsruhe

Amtsgericht Montabaur HRB 6484

Vorstand: Henning Ahlert, Ralph Dommermuth, Matthias Ehrlich, Thomas Gottschlich, Matthias Greve, Robert Hoffmann, Markus Huhn, Oliver Mauss, Achim Weiss
Aufsichtsratsvorsitzender: Michael Scheeren


-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|

Re: qx.ui.table.celleditor.ComboBox improvement

Romain FLIEDEL
Fabian Jakobs a Ć©crit :
> Can you please open a bug report for this and attach you patch. This
> really helps us to organize such improvements.
>
> Best Fabian
>  
Done (bug 1035)


This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.



-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel