Re: [qooxdoo-commit] SF.net SVN: qooxdoo: [14278] trunk/qooxdoo/frontend/framework/source/class/ qx/theme/manager/Appearance.js

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [qooxdoo-commit] SF.net SVN: qooxdoo: [14278] trunk/qooxdoo/frontend/framework/source/class/ qx/theme/manager/Appearance.js

Derrell Lipman
On Thu, Jul 3, 2008 at 6:27 AM, <[hidden email]> wrote:
Revision: 14278
         http://qooxdoo.svn.sourceforge.net/qooxdoo/?rev=14278&view=rev
Author:   wpbasti
Date:     2008-07-03 03:26:53 -0700 (Thu, 03 Jul 2008)

Log Message:
-----------
[API] Another change to the appearance system. The states field was too hard to use, even for me. Rethought the idea and came up with this one. Bit values for all incoming states are dynamically created. Each widget can only support a maximum of 30 states now (number overflow). The states field is not used anymore. Every incoming state is respected in bit-field generation. This means that even unsupported/unused states are substracted from the list of 30 possible states which is a bit bad, but should not really affect anyone. 30 states really seems to be a lot when looking into current widgets.

Wasn't there someone in Redmond, Washington who asked, "Who would ever need more than 640K of memory?" :-)

Suggestion: reserve one bit as an "extension" bit which is not to be used by any class for any purpose.  This allows you to use it later, should the need arise, to indicate that an additional bit mask is also in use or that some other, possibly less efficient but more expandable method of handling states is in use.  This requires that all current access to the bit masks themselves be disallowed (i.e. only access is via accessor methods) so that adding an alternate state implementation or an additional bit mask doesn't break existing code.

Cheers,

Derrell


-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|

Re: [qooxdoo-commit] SF.net SVN: qooxdoo: [14278] trunk/qooxdoo

Hugh Gibson-2
Derrell's suggestion sounds very sensible. What do you think, Sebastian?

Hugh

> > hard to use, even for me. Rethought the idea and came up with
> > this one. Bit values for all incoming states are dynamically
> > created. Each widget can only support a maximum of 30 states now
> > (number overflow). The states field is not used anymore. Every
> > incoming state is respected in bit-field generation. This means
> > that even unsupported/unused states are substracted from the list
> > of 30 possible states which is a bit bad, but should not really
> > affect anyone. 30 states really seems to be a lot when looking into
> > current widgets.
>
> Wasn't there someone in Redmond, Washington who asked, "Who would
> ever need more than 640K of memory?" :-)
>
> Suggestion: reserve one bit as an "extension" bit which is not to
> be used by any class for any purpose.  This allows you to use it
> later, should the need arise, to indicate that an additional bit
> mask is also in use or that some other, possibly less efficient but
> more expandable method of handling states is in use.  This requires
> that all current access to the bit masks themselves be disallowed
> (i.e. only access is via accessor methods) so that adding an
> alternate state implementation or an additional bit mask doesn't
> break existing code.

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel