FormController bubbling of <null> selection issue

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

FormController bubbling of <null> selection issue

Peter Schneider
Hi there,

I have a form (+controller) that uses -among others- a SelectBox with one
ListItem that has a model value of <null>.

It seems that selecting *that* item does not trigger the "changeBubble" event
of the model...

See playground example:
   http://tinyurl.com/qgxxzk6

The '0' (zero) item works however, but I have to distinguish <null> from zero!

Is this intentional or a bug? or did I miss something important here?

Thanks in advance for any tip/hint,
   Peter

--

** Unsere Veranstaltungen 2015

transport logistic München Halle B2, Stand 317/518 5.5.-8.5.2015
MöLo Kassel 18.6.-20.6.2015
Postexpo Paris 29.9.-1.10.2015

** NEU: Unser BLOG

telematics-magazine.com

------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|

Re: FormController bubbling of <null> selection issue

Daniel Wagner
Administrator
Hi Peter,

your use case looks valid to me. I did some digging and found the cause
of the issue in ui.form.MModelSelection.__onModelSelectionChange where
the selection is only changed if a non-null value is added.
Unfortunately, removing that check causes a ton of selection unit tests
to break, so we'll need to take a closer look to find a solution. Could
you please open a report for this issue? Make sure to include your
Playground link when you do, thanks.


Regards,
Daniel

On 27.02.2015 11:48, Peter Schneider wrote:

> Hi there,
>
> I have a form (+controller) that uses -among others- a SelectBox with one
> ListItem that has a model value of <null>.
>
> It seems that selecting *that* item does not trigger the "changeBubble" event
> of the model...
>
> See playground example:
>    http://tinyurl.com/qgxxzk6
>
> The '0' (zero) item works however, but I have to distinguish <null> from zero!
>
> Is this intentional or a bug? or did I miss something important here?
>
> Thanks in advance for any tip/hint,
>    Peter
>

------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|

Re: FormController bubbling of <null> selection issue

Peter Schneider
Hi Daniel,

thanks for the hint! The issue might be related to another bug-report[1] I've
opened some time ago ;)

Does the proposed fix (comment number 3)[2] make any difference in those
failed unit-tests?

Due to the fact that both issues seem to be related, there might be a fix for
both.

I'll wait until Monday to file a new bug -if it *is* new-

Thanks,
   Peter


[1] http://bugs.qooxdoo.org/show_bug.cgi?id=7565
[2] http://bugs.qooxdoo.org/show_bug.cgi?id=7565#c3



Am 2/27/2015 um 2:58 PM schrieb Daniel Wagner:

> Hi Peter,
>
> your use case looks valid to me. I did some digging and found the cause
> of the issue in ui.form.MModelSelection.__onModelSelectionChange where
> the selection is only changed if a non-null value is added.
> Unfortunately, removing that check causes a ton of selection unit tests
> to break, so we'll need to take a closer look to find a solution. Could
> you please open a report for this issue? Make sure to include your
> Playground link when you do, thanks.
>
>
> Regards,
> Daniel
>
> On 27.02.2015 11:48, Peter Schneider wrote:
>> Hi there,
>>
>> I have a form (+controller) that uses -among others- a SelectBox with one
>> ListItem that has a model value of <null>.
>>
>> It seems that selecting *that* item does not trigger the "changeBubble" event
>> of the model...
>>
>> See playground example:
>>     http://tinyurl.com/qgxxzk6
>>
>> The '0' (zero) item works however, but I have to distinguish <null> from zero!
>>
>> Is this intentional or a bug? or did I miss something important here?
>>
>> Thanks in advance for any tip/hint,
>>     Peter

--

** Unsere Veranstaltungen 2015

transport logistic München Halle B2, Stand 317/518 5.5.-8.5.2015
MöLo Kassel 18.6.-20.6.2015
Postexpo Paris 29.9.-1.10.2015

** NEU: Unser BLOG

telematics-magazine.com

------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|

Re: FormController bubbling of <null> selection issue

Daniel Wagner
Administrator
Yes, it looks like the same issue as described in bug #7565.
Unfortunately the tests still fail after applying the proposed fix.

On 27.02.2015 17:10, Peter Schneider wrote:

> Hi Daniel,
>
> thanks for the hint! The issue might be related to another bug-report[1] I've
> opened some time ago ;)
>
> Does the proposed fix (comment number 3)[2] make any difference in those
> failed unit-tests?
>
> Due to the fact that both issues seem to be related, there might be a fix for
> both.
>
> I'll wait until Monday to file a new bug -if it *is* new-
>
> Thanks,
>    Peter
>
>
> [1] http://bugs.qooxdoo.org/show_bug.cgi?id=7565
> [2] http://bugs.qooxdoo.org/show_bug.cgi?id=7565#c3
>
>
>
> Am 2/27/2015 um 2:58 PM schrieb Daniel Wagner:
>> Hi Peter,
>>
>> your use case looks valid to me. I did some digging and found the cause
>> of the issue in ui.form.MModelSelection.__onModelSelectionChange where
>> the selection is only changed if a non-null value is added.
>> Unfortunately, removing that check causes a ton of selection unit tests
>> to break, so we'll need to take a closer look to find a solution. Could
>> you please open a report for this issue? Make sure to include your
>> Playground link when you do, thanks.
>>
>>
>> Regards,
>> Daniel
>>
>> On 27.02.2015 11:48, Peter Schneider wrote:
>>> Hi there,
>>>
>>> I have a form (+controller) that uses -among others- a SelectBox with one
>>> ListItem that has a model value of <null>.
>>>
>>> It seems that selecting *that* item does not trigger the "changeBubble" event
>>> of the model...
>>>
>>> See playground example:
>>>     http://tinyurl.com/qgxxzk6
>>>
>>> The '0' (zero) item works however, but I have to distinguish <null> from zero!
>>>
>>> Is this intentional or a bug? or did I miss something important here?
>>>
>>> Thanks in advance for any tip/hint,
>>>     Peter
>

------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|

Re: FormController bubbling of <null> selection issue

Peter Schneider
Good morning Daniel,

Thanks for the information.

Can you tell me what unit-tests are complaining?

The (qooxdoo-3.0.2 based) tests I've run here locally seemed to be quite
happy...

But I am not 100% sure what other modifications to the 3.0.2 version I've made
to my clone[1] that might contribute to that result.

I am just asking because maybe the unit-tests are not checking
"expected behavior" but "experienced behavior" ---something I've seen in too
many test too many times ;)

/Peter


[1] That's why I don't like git. You never know what others have on their
     machine ;)


Am 3/2/2015 um 9:27 AM schrieb Daniel Wagner:

> Yes, it looks like the same issue as described in bug #7565.
> Unfortunately the tests still fail after applying the proposed fix.
>
> On 27.02.2015 17:10, Peter Schneider wrote:
>> Hi Daniel,
>>
>> thanks for the hint! The issue might be related to another bug-report[1] I've
>> opened some time ago ;)
>>
>> Does the proposed fix (comment number 3)[2] make any difference in those
>> failed unit-tests?
>>
>> Due to the fact that both issues seem to be related, there might be a fix for
>> both.
>>
>> I'll wait until Monday to file a new bug -if it *is* new-
>>
>> Thanks,
>>     Peter
>>
>>
>> [1] http://bugs.qooxdoo.org/show_bug.cgi?id=7565
>> [2] http://bugs.qooxdoo.org/show_bug.cgi?id=7565#c3
>>
>>
>>
>> Am 2/27/2015 um 2:58 PM schrieb Daniel Wagner:
>>> Hi Peter,
>>>
>>> your use case looks valid to me. I did some digging and found the cause
>>> of the issue in ui.form.MModelSelection.__onModelSelectionChange where
>>> the selection is only changed if a non-null value is added.
>>> Unfortunately, removing that check causes a ton of selection unit tests
>>> to break, so we'll need to take a closer look to find a solution. Could
>>> you please open a report for this issue? Make sure to include your
>>> Playground link when you do, thanks.
>>>
>>>
>>> Regards,
>>> Daniel
>>>
>>> On 27.02.2015 11:48, Peter Schneider wrote:
>>>> Hi there,
>>>>
>>>> I have a form (+controller) that uses -among others- a SelectBox with one
>>>> ListItem that has a model value of <null>.
>>>>
>>>> It seems that selecting *that* item does not trigger the "changeBubble" event
>>>> of the model...
>>>>
>>>> See playground example:
>>>>      http://tinyurl.com/qgxxzk6
>>>>
>>>> The '0' (zero) item works however, but I have to distinguish <null> from zero!
>>>>
>>>> Is this intentional or a bug? or did I miss something important here?
>>>>
>>>> Thanks in advance for any tip/hint,
>>>>      Peter

--

** Unsere Veranstaltungen 2015

transport logistic München Halle B2, Stand 317/518 5.5.-8.5.2015
MöLo Kassel 18.6.-20.6.2015
Postexpo Paris 29.9.-1.10.2015

** NEU: Unser BLOG

telematics-magazine.com

------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|

Re: FormController bubbling of <null> selection issue

Peter Schneider
Addendum:

I see that the "qx.test.ui.form.Resetter:testDifferentWidgets" tests fails
here, too :(

Why the model-selection influences the general-selection (of items by the
Resetter) is still a mystery to me :/

I would have expected that a selection change by the user (UI) would file a
"changeSelection" in any case,
but only file a "changeModelSelection" if the model is different.

Expected Behavior Overview:
---------------------------
#1 ListItem("one" , ..., 1);
#2 ListItem("two" , ..., 2);
#3 ListItem("none", ...   );
#4 ListItem("Eins", ..., 1);
#5 ListItem("Zwei", ..., 2);
#6 ListItem("Nix" , ...   );

Selecting (via UI)...
#1 => #2 : "changeSelection" + "changeModelSelection" (controller-bubble)
#1 => #3 : "changeSelection" + "changeModelSelection" (controller-bubble)
#1 => #4 : "changeSelection"
#1 => #5 : "changeSelection" + "changeModelSelection" (controller-bubble)
#1 => #5 : "changeSelection" + "changeModelSelection" (controller-bubble)

#2 => #5 : "changeSelection"
#3 => #6 : "changeSelection"
---------------------------

This should apply to *all* kind of item-models (null != undefined != String !=
Number)


Making this work as I expect it, might possibly break applications code in the
field, though.

I really would like to see this work as expected, but since this issue is still
untouched since July 2013 I think I have to live with a 'special' ListItem("-",
null,  "#nullModel#") work-around in my application.

/Peter


Am 3/2/2015 um 10:15 AM schrieb Peter Schneider:

> Good morning Daniel,
>
> Thanks for the information.
>
> Can you tell me what unit-tests are complaining?
>
> The (qooxdoo-3.0.2 based) tests I've run here locally seemed to be quite
> happy...
>
> But I am not 100% sure what other modifications to the 3.0.2 version I've made
> to my clone[1] that might contribute to that result.
>
> I am just asking because maybe the unit-tests are not checking
> "expected behavior" but "experienced behavior" ---something I've seen in too
> many test too many times ;)
>
> /Peter
>
>
> [1] That's why I don't like git. You never know what others have on their
>       machine ;)
>
>
> Am 3/2/2015 um 9:27 AM schrieb Daniel Wagner:
>> Yes, it looks like the same issue as described in bug #7565.
>> Unfortunately the tests still fail after applying the proposed fix.
>>
>> On 27.02.2015 17:10, Peter Schneider wrote:
>>> Hi Daniel,
>>>
>>> thanks for the hint! The issue might be related to another bug-report[1] I've
>>> opened some time ago ;)
>>>
>>> Does the proposed fix (comment number 3)[2] make any difference in those
>>> failed unit-tests?
>>>
>>> Due to the fact that both issues seem to be related, there might be a fix for
>>> both.
>>>
>>> I'll wait until Monday to file a new bug -if it *is* new-
>>>
>>> Thanks,
>>>      Peter
>>>
>>>
>>> [1] http://bugs.qooxdoo.org/show_bug.cgi?id=7565
>>> [2] http://bugs.qooxdoo.org/show_bug.cgi?id=7565#c3
>>>
>>>
>>>
>>> Am 2/27/2015 um 2:58 PM schrieb Daniel Wagner:
>>>> Hi Peter,
>>>>
>>>> your use case looks valid to me. I did some digging and found the cause
>>>> of the issue in ui.form.MModelSelection.__onModelSelectionChange where
>>>> the selection is only changed if a non-null value is added.
>>>> Unfortunately, removing that check causes a ton of selection unit tests
>>>> to break, so we'll need to take a closer look to find a solution. Could
>>>> you please open a report for this issue? Make sure to include your
>>>> Playground link when you do, thanks.
>>>>
>>>>
>>>> Regards,
>>>> Daniel
>>>>
>>>> On 27.02.2015 11:48, Peter Schneider wrote:
>>>>> Hi there,
>>>>>
>>>>> I have a form (+controller) that uses -among others- a SelectBox with one
>>>>> ListItem that has a model value of <null>.
>>>>>
>>>>> It seems that selecting *that* item does not trigger the "changeBubble" event
>>>>> of the model...
>>>>>
>>>>> See playground example:
>>>>>       http://tinyurl.com/qgxxzk6
>>>>>
>>>>> The '0' (zero) item works however, but I have to distinguish <null> from zero!
>>>>>
>>>>> Is this intentional or a bug? or did I miss something important here?
>>>>>
>>>>> Thanks in advance for any tip/hint,
>>>>>       Peter
>

--

** Unsere Veranstaltungen 2015

transport logistic München Halle B2, Stand 317/518 5.5.-8.5.2015
MöLo Kassel 18.6.-20.6.2015
Postexpo Paris 29.9.-1.10.2015

** NEU: Unser BLOG

telematics-magazine.com

------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel