Few patches for core framework

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Few patches for core framework

Sebastian Werner-2
Hi all!

I have attached a few modifications I would like to see to be applied
to qooxdoo. Most of them are quite small. I am not sure about the best
process here. A small description of the changes:

Html.patch:
- Added support for objects being in the list of "clean" elements.
This allows to use qx.bom.Html together with controls which returns a
DOM element. It would be hightly appreciated to see this as soon as
possible in trunk.

Manager.patch
- When no event handler is found for a specific case, an exception is
thrown. The error message handling is optimized for qooxdoo objects
but does not work well with other things like DOM nodes. I made this
is bit more generic.

ObjectPool.patch:
- Minor optimizations for length checks. Correctly changed default
value for "size".
- Added support for optional destroy() method on managed elements
instead of just "dispose()" which is sometimes not enough when working
with queues etc.

Template.patch:
- Corrected an issue that the "run" method was cached even after the
content was removed.

Cheers,
Sebastian

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

Html.patch (738 bytes) Download Attachment
Manager.patch (1K) Download Attachment
ObjectPool.patch (1K) Download Attachment
Template.patch (972 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Few patches for core framework

Fabian Jakobs
Administrator
Hi Sebastian,

> I have attached a few modifications I would like to see to be applied
> to qooxdoo. Most of them are quite small. I am not sure about the best
> process here. A small description of the changes:
>
> Html.patch:
> - Added support for objects being in the list of "clean" elements.
> This allows to use qx.bom.Html together with controls which returns a
> DOM element. It would be hightly appreciated to see this as soon as
> possible in trunk.
>  

applied

> Manager.patch
> - When no event handler is found for a specific case, an exception is
> thrown. The error message handling is optimized for qooxdoo objects
> but does not work well with other things like DOM nodes. I made this
> is bit more generic.
>  

applied

> ObjectPool.patch:
> - Minor optimizations for length checks. Correctly changed default
> value for "size".
> - Added support for optional destroy() method on managed elements
> instead of just "dispose()" which is sometimes not enough when working
> with queues etc.
>  

applied

> Template.patch:
> - Corrected an issue that the "run" method was cached even after the
> content was removed.
>  

applied. In addition I've moved the code from the demobrowser demo
(test.Template) into a unit test (qx.test.util.Template). Still I'm not
sure if you are doing the right thing here. Deleting the "run" method
will result in an exception if it is called. Wouldn't it be better to do
something like this:

this.run = function() {return ""; };


Best Fabian

--
Fabian Jakobs
JavaScript Framework Developer

1&1 Internet AG - Web Technologies
Ernst-Frey-Straße 9 · DE-76135 Karlsruhe
Telefon: +49 721 91374-6784
[hidden email]

Amtsgericht Montabaur / HRB 6484
Vorstände: Henning Ahlert, Ralph Dommermuth, Matthias Ehrlich, Thomas Gottschlich, Robert Hoffmann, Markus Huhn, Hans-Henning Kettler, Dr. Oliver Mauss, Jan Oetjen
Aufsichtsratsvorsitzender: Michael Scheeren


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|

Re: Few patches for core framework

Sebastian Werner-2
Thanks Fabian!

Deleting the method falls back to the prototype method on the members
chain. At least this is what I would expect. So you get a clear
exception describing the problem as there is a default method defined
in the "members" section.

Cheers,
Sebastian





2009/11/16 Fabian Jakobs <[hidden email]>:

> Hi Sebastian,
>> I have attached a few modifications I would like to see to be applied
>> to qooxdoo. Most of them are quite small. I am not sure about the best
>> process here. A small description of the changes:
>>
>> Html.patch:
>> - Added support for objects being in the list of "clean" elements.
>> This allows to use qx.bom.Html together with controls which returns a
>> DOM element. It would be hightly appreciated to see this as soon as
>> possible in trunk.
>>
>
> applied
>
>> Manager.patch
>> - When no event handler is found for a specific case, an exception is
>> thrown. The error message handling is optimized for qooxdoo objects
>> but does not work well with other things like DOM nodes. I made this
>> is bit more generic.
>>
>
> applied
>
>> ObjectPool.patch:
>> - Minor optimizations for length checks. Correctly changed default
>> value for "size".
>> - Added support for optional destroy() method on managed elements
>> instead of just "dispose()" which is sometimes not enough when working
>> with queues etc.
>>
>
> applied
>
>> Template.patch:
>> - Corrected an issue that the "run" method was cached even after the
>> content was removed.
>>
>
> applied. In addition I've moved the code from the demobrowser demo
> (test.Template) into a unit test (qx.test.util.Template). Still I'm not
> sure if you are doing the right thing here. Deleting the "run" method
> will result in an exception if it is called. Wouldn't it be better to do
> something like this:
>
> this.run = function() {return ""; };
>
>
> Best Fabian
>
> --
> Fabian Jakobs
> JavaScript Framework Developer
>
> 1&1 Internet AG - Web Technologies
> Ernst-Frey-Straße 9 · DE-76135 Karlsruhe
> Telefon: +49 721 91374-6784
> [hidden email]
>
> Amtsgericht Montabaur / HRB 6484
> Vorstände: Henning Ahlert, Ralph Dommermuth, Matthias Ehrlich, Thomas Gottschlich, Robert Hoffmann, Markus Huhn, Hans-Henning Kettler, Dr. Oliver Mauss, Jan Oetjen
> Aufsichtsratsvorsitzender: Michael Scheeren
>
>
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
> trial. Simplify your report design, integration and deployment - and focus on
> what you do best, core application coding. Discover what's new with
> Crystal Reports now.  http://p.sf.net/sfu/bobj-july
> _______________________________________________
> qooxdoo-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
>

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel