Drag & Drop changes

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Drag & Drop changes

Johan
Hi !

I need to update my qooxdoo framework (4.0.1 to 5), but the drag & drop function doesn't working with version 5 (in my case).

Playground example for drag : http://tinyurl.com/zlw9fhl

Any ideas ?

Regards,

Johan

------------------------------------------------------------------------------

_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Drag & Drop changes

John Spackman-3
Hi Johan

It does look like it’s working – the button is dragging, but there is nowhere to drop it onto.  You need to create a drop target and set it’s droppable property to true

Regards
John

From: Johan <[hidden email]>
Reply-To: qooxdoo Development <[hidden email]>
Date: Thursday, 7 January 2016 at 09:00
To: qooxdoo Development <[hidden email]>
Subject: [qooxdoo-devel] Drag & Drop changes

Hi !

I need to update my qooxdoo framework (4.0.1 to 5), but the drag & drop function doesn't working with version 5 (in my case).

Playground example for drag : http://tinyurl.com/zlw9fhl

Any ideas ?

Regards,

Johan
------------------------------------------------------------------------------ _______________________________________________ qooxdoo-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

------------------------------------------------------------------------------

_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Drag & Drop changes

Johan
Thank for reply,

yes of course, but just a dragging, doesn't working in version 5 ! My example is in version 4.0.1.

Regards,

Johan

Le 07/01/2016 10:17, John Spackman a écrit :
Hi Johan

It does look like it’s working – the button is dragging, but there is nowhere to drop it onto.  You need to create a drop target and set it’s droppable property to true

Regards
John

From: Johan <[hidden email]>
Reply-To: qooxdoo Development <[hidden email]>
Date: Thursday, 7 January 2016 at 09:00
To: qooxdoo Development <[hidden email]>
Subject: [qooxdoo-devel] Drag & Drop changes

Hi !

I need to update my qooxdoo framework (4.0.1 to 5), but the drag & drop function doesn't working with version 5 (in my case).

Playground example for drag : http://tinyurl.com/zlw9fhl

Any ideas ?

Regards,

Johan
------------------------------------------------------------------------------ _______________________________________________ qooxdoo-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel


------------------------------------------------------------------------------


_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel


------------------------------------------------------------------------------

_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Drag & Drop changes

Johan
Same code in playground 5.0.1 : http://tinyurl.com/gt2shgp not work...

Regards,

Johan

------------------------------------------------------------------------------

_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Drag & Drop changes

Daniel Lenggenhager
Hi Johan,

I changed the Button widget with a Label widget... and it's working.
Maybe something has been changed with the form widgets... but I haven't found any hints in the source...

Regards,
Daniel

Am 07.01.2016 um 10:45 schrieb Johan:

Same code in playground 5.0.1 : http://tinyurl.com/gt2shgp not work...

Regards,

Johan


------------------------------------------------------------------------------


_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel


------------------------------------------------------------------------------

_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Drag & Drop changes

John Spackman-3
In reply to this post by Johan
Ah, I see what you mean!  I just tried it with a label instead of a button and it works fine, so I guess it’s a regression associated with widgets that have input.  You could try filing a bug report, and it would be great if you could find the cause (if you can fix it, you could also file a pull request!)

In the mean time though – does it have to be a button?  Could you use something else that does not trigger the problem?

John

From: Johan <[hidden email]>
Reply-To: qooxdoo Development <[hidden email]>
Date: Thursday, 7 January 2016 at 09:45
To: qooxdoo Development <[hidden email]>
Subject: Re: [qooxdoo-devel] Drag & Drop changes

Same code in playground 5.0.1 : http://tinyurl.com/gt2shgp not work...

Regards,

Johan
------------------------------------------------------------------------------ _______________________________________________ qooxdoo-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

------------------------------------------------------------------------------

_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Drag & Drop changes

Johan
Thank you for your replies !

I'm trying label for my app, but i'm searching the regression too !
This regression started in version 4.02 !

Regards

Johan

Le 07/01/2016 11:10, John Spackman a écrit :
Ah, I see what you mean!  I just tried it with a label instead of a button and it works fine, so I guess it’s a regression associated with widgets that have input.  You could try filing a bug report, and it would be great if you could find the cause (if you can fix it, you could also file a pull request!)

In the mean time though – does it have to be a button?  Could you use something else that does not trigger the problem?

John

From: Johan <[hidden email]>
Reply-To: qooxdoo Development <[hidden email]>
Date: Thursday, 7 January 2016 at 09:45
To: qooxdoo Development <[hidden email]>
Subject: Re: [qooxdoo-devel] Drag & Drop changes

Same code in playground 5.0.1 : http://tinyurl.com/gt2shgp not work...

Regards,

Johan
------------------------------------------------------------------------------ _______________________________________________ qooxdoo-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel


------------------------------------------------------------------------------


_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel


------------------------------------------------------------------------------

_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Drag & Drop changes

Dietrich Streifert
In reply to this post by Daniel Lenggenhager
It seems the change came in between 4.0.1 and 4.0.2.

Simply change the playground link from http://demo.qooxdoo.org/4.0.1/.... to http://demo.qooxdoo.org/4.0.2/.... while preserving the rest of the link (which encodes the test case).

It works with 4.0.1 but not with 4.0.2

Dietrich

Am 07.01.2016 um 10:52 schrieb Daniel Lenggenhager:
Hi Johan,

I changed the Button widget with a Label widget... and it's working.
Maybe something has been changed with the form widgets... but I haven't found any hints in the source...

Regards,
Daniel



------------------------------------------------------------------------------

_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Drag & Drop changes

Qoo Goo
It seems to be related to this bug (if not the same):

 http://bugzilla.qooxdoo.org/show_bug.cgi?id=9187.

I uploaded a patch for it and there is a push request for it.


On 07/01/16 11:39, Dietrich Streifert wrote:
It seems the change came in between 4.0.1 and 4.0.2.

Simply change the playground link from http://demo.qooxdoo.org/4.0.1/.... to http://demo.qooxdoo.org/4.0.2/.... while preserving the rest of the link (which encodes the test case).

It works with 4.0.1 but not with 4.0.2

Dietrich

Am 07.01.2016 um 10:52 schrieb Daniel Lenggenhager:
Hi Johan,

I changed the Button widget with a Label widget... and it's working.
Maybe something has been changed with the form widgets... but I haven't found any hints in the source...

Regards,
Daniel




------------------------------------------------------------------------------


_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel


------------------------------------------------------------------------------

_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Drag & Drop changes

Dietrich Streifert
In reply to this post by Johan
I can't find which commit broke dragging, but I've found where it happens:

http://tinyurl.com/hg5r93o

The pointerdown handler of the button stops propagation of the event, thus not allowing bubbling up to the root widget, which has the drag and drop handler attached.


Dietrich


Am 07.01.2016 um 11:38 schrieb Johan:
Thank you for your replies !

I'm trying label for my app, but i'm searching the regression too !
This regression started in version 4.02 !

Regards

Johan


------------------------------------------------------------------------------

_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Drag & Drop changes

Qoo Goo
Check the link I sent before:

http://bugzilla.qooxdoo.org/show_bug.cgi?id=9187

If the bug is the same or has the same origin (I'd bet), the commit may be the 'ad38c72a3cbcbb61132504d7454d512eddbcf4a4'. You can find it in the link above.



On 07/01/16 12:51, Dietrich Streifert wrote:
I can't find which commit broke dragging, but I've found where it happens:

http://tinyurl.com/hg5r93o

The pointerdown handler of the button stops propagation of the event, thus not allowing bubbling up to the root widget, which has the drag and drop handler attached.


Dietrich


Am 07.01.2016 um 11:38 schrieb Johan:
Thank you for your replies !

I'm trying label for my app, but i'm searching the regression too !
This regression started in version 4.02 !

Regards

Johan



------------------------------------------------------------------------------


_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel


------------------------------------------------------------------------------

_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Drag & Drop changes

Johan
@Qoo : Thanks for the patch but it's not working !
However, Dietrich's patch is working ! Thank a lot !

A patch in framework would be better.

Regards,

Johan


Le 07/01/2016 13:04, Qoo a écrit :
Check the link I sent before:

http://bugzilla.qooxdoo.org/show_bug.cgi?id=9187

If the bug is the same or has the same origin (I'd bet), the commit may be the 'ad38c72a3cbcbb61132504d7454d512eddbcf4a4'. You can find it in the link above.



On 07/01/16 12:51, Dietrich Streifert wrote:
I can't find which commit broke dragging, but I've found where it happens:

http://tinyurl.com/hg5r93o

The pointerdown handler of the button stops propagation of the event, thus not allowing bubbling up to the root widget, which has the drag and drop handler attached.


Dietrich


Am 07.01.2016 um 11:38 schrieb Johan:
Thank you for your replies !

I'm trying label for my app, but i'm searching the regression too !
This regression started in version 4.02 !

Regards

Johan



------------------------------------------------------------------------------


_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel



------------------------------------------------------------------------------


_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel


------------------------------------------------------------------------------

_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Drag & Drop changes

Dietrich Streifert
In reply to this post by John Spackman-3
Hi All,

here is the filed bugzilla bug:

     http://bugzilla.qooxdoo.org/show_bug.cgi?id=9243

and a (possible) fix:

     https://github.com/qooxdoo/qooxdoo/pull/165

Dietrich


Am 07.01.2016 um 11:10 schrieb John Spackman:

> Ah, I see what you mean!  I just tried it with a label instead of a
> button and it works fine, so I guess it’s a regression associated with
> widgets that have input.  You could try filing a bug report, and it
> would be great if you could find the cause (if you can fix it, you
> could also file a pull request!)
>
> In the mean time though – does it have to be a button?  Could you use
> something else that does not trigger the problem?
>
> John
>
>

------------------------------------------------------------------------------
_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Drag & Drop changes

Dietrich Streifert
In reply to this post by Johan
Hi Johan,

this was not a patch, but a test case to narrow down the issue.

Please try

    https://github.com/qooxdoo/qooxdoo/pull/165

instead.


Am 07.01.2016 um 13:24 schrieb Johan:
@Qoo : Thanks for the patch but it's not working !
However, Dietrich's patch is working ! Thank a lot !

A patch in framework would be better.

Regards,

Johan




------------------------------------------------------------------------------

_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Drag & Drop changes

Johan
Nice !!! it's working !

Is your commit ? (commited only 20 minutes ago ? :))

Thanks a lot !!!

Regards

Johan

Le 07/01/2016 13:43, Dietrich Streifert a écrit :
Hi Johan,

this was not a patch, but a test case to narrow down the issue.

Please try

    https://github.com/qooxdoo/qooxdoo/pull/165

instead.


Am 07.01.2016 um 13:24 schrieb Johan:
@Qoo : Thanks for the patch but it's not working !
However, Dietrich's patch is working ! Thank a lot !

A patch in framework would be better.

Regards,

Johan





------------------------------------------------------------------------------


_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel


------------------------------------------------------------------------------

_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Drag & Drop changes

Dietrich Streifert
Yep! It's my (aka level420) commit.

Please report if you find any Problems with this patch.

Dietrich

Am 07.01.2016 um 13:55 schrieb Johan:
Nice !!! it's working !

Is your commit ? (commited only 20 minutes ago ? :))

Thanks a lot !!!

Regards

Johan



------------------------------------------------------------------------------

_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Drag & Drop changes

Johan
ok ! No problem !

Thanks again,

Regards

Johan

Le 07/01/2016 14:01, Dietrich Streifert a écrit :
Yep! It's my (aka level420) commit.

Please report if you find any Problems with this patch.

Dietrich

Am 07.01.2016 um 13:55 schrieb Johan:
Nice !!! it's working !

Is your commit ? (commited only 20 minutes ago ? :))

Thanks a lot !!!

Regards

Johan




------------------------------------------------------------------------------


_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel


------------------------------------------------------------------------------

_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Loading...