Bug introduced in 4.0.2 by bugfix on qx.event.handler.Pointer

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug introduced in 4.0.2 by bugfix on qx.event.handler.Pointer

Jeroen Smit-2

Hi,

 

I have just upgraded to the bugfixing release 4.0.2 and I noticed a side effect of the change on qx.event.handler.Pointer in which the following check has been added:

 

// respect anonymous elements

while (target && target.getAttribute("qxanonymous")) {

  target = target.parentNode

}

 

This causes mouse and pointer events to not be propagated to widgets that received these events before and should (I believe).

The easiest way to see this is in the playground (http://demo.qooxdoo.org/current/playground/#Table-ria) by adding a listener to event “pointerdown” on child “column-button” of the table, e.g.

 

var customizingButton = table.getChildControl("column-button");

if (customizingButton != null) {

  alert("button found");

  customizingButton.addListener("pointerdown", function (e) {

    alert("pointerdown");

    if (e.isLeftPressed()) {

      alert("pointerdown");

    }

  }, this, true);

}

 

The alert that the button is found is shown but none of the alerts inside the listener. Using “mousedown” which should still work too according to the documentation has no effect.

 

I reverted the change in qx.event.handler.Pointer and now my code works again.

 

Question is, is this a bug in qx.event.handler.Pointer or is the column-button missing a property?

Please let me know and I will open a bugreport

 

Regards,

Jeroen

 


------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|

Re: Bug introduced in 4.0.2 by bugfix on qx.event.handler.Pointer

MartinWittemann
Administrator
Hey,
sounds like a bug to me. Could you open an issue in bugzilla for use?
Regards,
Martin


> Am 14.01.2015 um 10:07 schrieb Jeroen Smit <[hidden email]>:
>
> Hi,
>
>  
>
> I have just upgraded to the bugfixing release 4.0.2 and I noticed a side effect of the change on qx.event.handler.Pointer in which the following check has been added:
>
>  
>
> // respect anonymous elements
>
> while (target && target.getAttribute("qxanonymous")) {
>
>   target = target.parentNode
>
> }
>
>  
>
> This causes mouse and pointer events to not be propagated to widgets that received these events before and should (I believe).
>
> The easiest way to see this is in the playground “pointerdown” on child “column-button” of the table, e.g.
>
>  
>
> var customizingButton = table.getChildControl("column-button");
>
> if (customizingButton != null) {
>
>   alert("button found");
>
>   customizingButton.addListener("pointerdown", function (e) {
>
>     alert("pointerdown");
>
>     if (e.isLeftPressed()) {
>
>       alert("pointerdown");
>
>     }
>
>   }, this, true);
>
> }
>
>  
>
> The alert that the button is found is shown but none of the alerts inside the listener. Using “mousedown” which should still work too according to the documentation has no effect.
>
>  
>
> I reverted the change in qx.event.handler.Pointer and now my code works again.
>
>  
>
> Question is, is this a bug in qx.event.handler.Pointer or is the column-button missing a property?
>
> Please let me know and I will open a bugreport
>
>  
>
> Regards,
>
> Jeroen
>
>  
>
> ------------------------------------------------------------------------------
> New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
> GigeNET is offering a free month of service with a new server in Ashburn.
> Choose from 2 high performing configs, both with 100TB of bandwidth.
> Higher redundancy.Lower latency.Increased capacity.Completely compliant.
> http://p.sf.net/sfu/gigenet_______________________________________________
> qooxdoo-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|

Re: Bug introduced in 4.0.2 by bugfix on qx.event.handler.Pointer

Jeroen Smit-2
Hi,

And what do you think the bug is? The new code or the button's properties?
That helps filing the bug.

What I noticed debugging is that when clicking the column-button the new loop in qx.event.handler.Pointer actually processes an event on the image on the button and the image is anonymous. The loop, looking for the parent node, doesn't reach the button so the event goes off in the wrong place

Regards,
 Jeroen

-----Original Message-----
From: Martin Wittemann [mailto:[hidden email]]
Sent: woensdag 14 januari 2015 16:29
To: qooxdoo Development
Subject: Re: [qooxdoo-devel] Bug introduced in 4.0.2 by bugfix on qx.event.handler.Pointer

Hey,
sounds like a bug to me. Could you open an issue in bugzilla for use?
Regards,
Martin


> Am 14.01.2015 um 10:07 schrieb Jeroen Smit <[hidden email]>:
>
> Hi,
>
>  
>
> I have just upgraded to the bugfixing release 4.0.2 and I noticed a side effect of the change on qx.event.handler.Pointer in which the following check has been added:
>
>  
>
> // respect anonymous elements
>
> while (target && target.getAttribute("qxanonymous")) {
>
>   target = target.parentNode
>
> }
>
>  
>
> This causes mouse and pointer events to not be propagated to widgets that received these events before and should (I believe).
>
> The easiest way to see this is in the playground “pointerdown” on child “column-button” of the table, e.g.
>
>  
>
> var customizingButton = table.getChildControl("column-button");
>
> if (customizingButton != null) {
>
>   alert("button found");
>
>   customizingButton.addListener("pointerdown", function (e) {
>
>     alert("pointerdown");
>
>     if (e.isLeftPressed()) {
>
>       alert("pointerdown");
>
>     }
>
>   }, this, true);
>
> }
>
>  
>
> The alert that the button is found is shown but none of the alerts inside the listener. Using “mousedown” which should still work too according to the documentation has no effect.
>
>  
>
> I reverted the change in qx.event.handler.Pointer and now my code works again.
>
>  
>
> Question is, is this a bug in qx.event.handler.Pointer or is the column-button missing a property?
>
> Please let me know and I will open a bugreport
>
>  
>
> Regards,
>
> Jeroen
>
>  
>
> ----------------------------------------------------------------------
> -------- New Year. New Location. New Benefits. New Data Center in
> Ashburn, VA.
> GigeNET is offering a free month of service with a new server in Ashburn.
> Choose from 2 high performing configs, both with 100TB of bandwidth.
> Higher redundancy.Lower latency.Increased capacity.Completely compliant.
> http://p.sf.net/sfu/gigenet___________________________________________
> ____
> qooxdoo-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|

Re: Bug introduced in 4.0.2 by bugfix on qx.event.handler.Pointer

Jeroen Smit-2
In reply to this post by MartinWittemann
Hi,

I filed http://bugzilla.qooxdoo.org/show_bug.cgi?id=8871

Regards,
 Jeroen

________________________________________
From: Martin Wittemann [[hidden email]]
Sent: 14 January 2015 16:28
To: qooxdoo Development
Subject: Re: [qooxdoo-devel] Bug introduced in 4.0.2 by bugfix  on      qx.event.handler.Pointer

Hey,
sounds like a bug to me. Could you open an issue in bugzilla for use?
Regards,
Martin


> Am 14.01.2015 um 10:07 schrieb Jeroen Smit <[hidden email]>:
>
> Hi,
>
>
>
> I have just upgraded to the bugfixing release 4.0.2 and I noticed a side effect of the change on qx.event.handler.Pointer in which the following check has been added:
>
>
>
> // respect anonymous elements
>
> while (target && target.getAttribute("qxanonymous")) {
>
>   target = target.parentNode
>
> }
>
>
>
> This causes mouse and pointer events to not be propagated to widgets that received these events before and should (I believe).
>
> The easiest way to see this is in the playground “pointerdown” on child “column-button” of the table, e.g.
>
>
>
> var customizingButton = table.getChildControl("column-button");
>
> if (customizingButton != null) {
>
>   alert("button found");
>
>   customizingButton.addListener("pointerdown", function (e) {
>
>     alert("pointerdown");
>
>     if (e.isLeftPressed()) {
>
>       alert("pointerdown");
>
>     }
>
>   }, this, true);
>
> }
>
>
>
> The alert that the button is found is shown but none of the alerts inside the listener. Using “mousedown” which should still work too according to the documentation has no effect.
>
>
>
> I reverted the change in qx.event.handler.Pointer and now my code works again.
>
>
>
> Question is, is this a bug in qx.event.handler.Pointer or is the column-button missing a property?
>
> Please let me know and I will open a bugreport
>
>
>
> Regards,
>
> Jeroen
>
>
>
> ------------------------------------------------------------------------------
> New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
> GigeNET is offering a free month of service with a new server in Ashburn.
> Choose from 2 high performing configs, both with 100TB of bandwidth.
> Higher redundancy.Lower latency.Increased capacity.Completely compliant.
> http://p.sf.net/sfu/gigenet_______________________________________________
> qooxdoo-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|

Re: Bug introduced in 4.0.2 by bugfix on qx.event.handler.Pointer

MartinWittemann
Administrator
Thanks. :)

> Am 16.01.2015 um 10:08 schrieb Jeroen Smit <[hidden email]>:
>
> Hi,
>
> I filed http://bugzilla.qooxdoo.org/show_bug.cgi?id=8871
>
> Regards,
> Jeroen
>
> ________________________________________
> From: Martin Wittemann [[hidden email]]
> Sent: 14 January 2015 16:28
> To: qooxdoo Development
> Subject: Re: [qooxdoo-devel] Bug introduced in 4.0.2 by bugfix  on      qx.event.handler.Pointer
>
> Hey,
> sounds like a bug to me. Could you open an issue in bugzilla for use?
> Regards,
> Martin
>
>
>> Am 14.01.2015 um 10:07 schrieb Jeroen Smit <[hidden email]>:
>>
>> Hi,
>>
>>
>>
>> I have just upgraded to the bugfixing release 4.0.2 and I noticed a side effect of the change on qx.event.handler.Pointer in which the following check has been added:
>>
>>
>>
>> // respect anonymous elements
>>
>> while (target && target.getAttribute("qxanonymous")) {
>>
>>  target = target.parentNode
>>
>> }
>>
>>
>>
>> This causes mouse and pointer events to not be propagated to widgets that received these events before and should (I believe).
>>
>> The easiest way to see this is in the playground “pointerdown” on child “column-button” of the table, e.g.
>>
>>
>>
>> var customizingButton = table.getChildControl("column-button");
>>
>> if (customizingButton != null) {
>>
>>  alert("button found");
>>
>>  customizingButton.addListener("pointerdown", function (e) {
>>
>>    alert("pointerdown");
>>
>>    if (e.isLeftPressed()) {
>>
>>      alert("pointerdown");
>>
>>    }
>>
>>  }, this, true);
>>
>> }
>>
>>
>>
>> The alert that the button is found is shown but none of the alerts inside the listener. Using “mousedown” which should still work too according to the documentation has no effect.
>>
>>
>>
>> I reverted the change in qx.event.handler.Pointer and now my code works again.
>>
>>
>>
>> Question is, is this a bug in qx.event.handler.Pointer or is the column-button missing a property?
>>
>> Please let me know and I will open a bugreport
>>
>>
>>
>> Regards,
>>
>> Jeroen
>>
>>
>>
>> ------------------------------------------------------------------------------
>> New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
>> GigeNET is offering a free month of service with a new server in Ashburn.
>> Choose from 2 high performing configs, both with 100TB of bandwidth.
>> Higher redundancy.Lower latency.Increased capacity.Completely compliant.
>> http://p.sf.net/sfu/gigenet_______________________________________________
>> qooxdoo-devel mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
>
> ------------------------------------------------------------------------------
> New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
> GigeNET is offering a free month of service with a new server in Ashburn.
> Choose from 2 high performing configs, both with 100TB of bandwidth.
> Higher redundancy.Lower latency.Increased capacity.Completely compliant.
> http://p.sf.net/sfu/gigenet
> _______________________________________________
> qooxdoo-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
> ------------------------------------------------------------------------------
> New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
> GigeNET is offering a free month of service with a new server in Ashburn.
> Choose from 2 high performing configs, both with 100TB of bandwidth.
> Higher redundancy.Lower latency.Increased capacity.Completely compliant.
> http://p.sf.net/sfu/gigenet
> _______________________________________________
> qooxdoo-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel


------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel