0.8.1 Three bugs in tool/pylib/generator/Generator.py when using packages/parts

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

0.8.1 Three bugs in tool/pylib/generator/Generator.py when using packages/parts

WillP-2
When using a config.json which defines packages with mutilple parts the Generator script fails

  1. Line 397:
    parts, packages = self._partBuilder.getPackages(partIncludes, smartExclude, classList, collapseCfg, variants, minPackageSize, minPackageSizeForUnshared)
    
    self._partBuilder has not been assigned.

  2. Line 408:
    self.runApiData(packageClasses)
    
    packageClasses is only assigned in the else block of the preceeding if self._job.get("packages"): and not both.

  3. Line 410:
    self.runSource(partPackages, packageClasses, boot, variants)
    
    partPackages is only assigned in the else block of the preceeding if self._job.get("packages"): and not both.


View this message in context: 0.8.1 Three bugs in tool/pylib/generator/Generator.py when using packages/parts
Sent from the qooxdoo-devel mailing list archive at Nabble.com.

------------------------------------------------------------------------------

_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
Reply | Threaded
Open this post in threaded view
|

Re: 0.8.1 Three bugs in tool/pylib/generator/Generator.py when using packages/parts

Thomas Herchenroeder
Hi Will,

thanks for the report, the issue has been fixed in trunk.

Cheers,
Thomas

WillP wrote:

> When using a config.json which defines packages with mutilple parts the
> Generator script fails
>
>
> Line 397:
>
> parts, packages = self._partBuilder.getPackages(partIncludes, smartExclude,
> classList, collapseCfg, variants, minPackageSize, minPackageSizeForUnshared)
>
> self._partBuilder has not been assigned.
>
> Line 408:
>
> self.runApiData(packageClasses)
>
> packageClasses is only assigned in the else block of the preceeding if
> self._job.get("packages"): and not both.
>
> Line 410:
>
> self.runSource(partPackages, packageClasses, boot, variants)
>
> partPackages is only assigned in the else block of the preceeding if
> self._job.get("packages"): and not both.
>
>  
> ------------------------------------------------------------------------
>
> ------------------------------------------------------------------------------
>  
> ------------------------------------------------------------------------
>
> _______________________________________________
> qooxdoo-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
>  

------------------------------------------------------------------------------
_______________________________________________
qooxdoo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel